Utilities: Add the pcfconv utility #25374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tool is able to convert an X11 PCF font to Serenity's font format. These pcf files are a fairly common bitmap font format, and with this we are easily able to use many of them.
github-actions
bot
added
the
👀 pr-needs-review
|
Could also turn this into a parser in LibGfx, not sure what makes more sense. |
nico
reviewed
Nov 12, 2024
| else | ||
| value = TRY(m_stream.read_value<LittleEndian<T>>()); | ||
|
|
||
| if (!(format & PCF_BIT_MASK)) |
| i32 size; | ||
| i32 offset; | ||
| }; | ||
| }; |
| { | ||
| StringBuilder builder; | ||
| if (m_properties.contains("WEIGHT_NAME"sv)) | ||
| builder.append(m_properties.get("WEIGHT_NAME"sv).value().get<String>()); |
There was a problem hiding this comment.
Should we we validate property types?
| m_encoding.max_byte1 = TRY(read<i16>(format)); | ||
| m_encoding.default_char = TRY(read<i16>(format)); | ||
|
|
||
| size_t num = (m_encoding.max_char_or_byte2 - m_encoding.min_char_or_byte2 + 1) |
There was a problem hiding this comment.
Should we check that min < max?
| if (table_index < 0) | ||
| return {}; | ||
|
|
||
| if (table_index >= static_cast<ssize_t>(m_encoding.indices.size())) |
There was a problem hiding this comment.
Does this happen? Should we error out instead?
| auto pcf = TRY(PCFFile::create(buffer)); | ||
|
|
||
| if (pcf->glyph_size().width() > 32 || pcf->glyph_size().height() > 32) { | ||
| outln(stderr, "At this time, glyphs may only be 32px wide"); |
| ErrorOr<void> draw_glyph(u16 index, Gfx::GlyphBitmap&) const; | ||
| u8 glyph_width(u16 index) const { return m_glyphs.at(index).width; } | ||
| u8 baseline() const; | ||
| size_t highest_codepoint() const; |
There was a problem hiding this comment.
Can this be larger than u16? The mapping only has 16bit values for min and max afaict.
nico
added
⏳ pr-waiting-for-author
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool is able to convert an X11 PCF font to Serenity's font format. These pcf files are a fairly common bitmap font format, and with this we are easily able to use many of them.